Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PFD Briefing Page #177

Merged
merged 1 commit into from
Sep 23, 2021
Merged

feat: PFD Briefing Page #177

merged 1 commit into from
Sep 23, 2021

Conversation

oim1
Copy link
Contributor

@oim1 oim1 commented Aug 23, 2021 •
edited by frankkopp
Loading

Detailed PFD overview.

image

@vercel
Copy link

vercel bot commented Aug 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flybywire/docs/CchnjYx19xMDu5G7GndJV6WDM5n4
✅ Preview: https://docs-git-fork-oim1-briefing-pfd-flybywire.vercel.app

@oim1 oim1 marked this pull request as draft August 23, 2021 10:33
@oim1 oim1 changed the title PFD Briefing Page feat: PFD Briefing Page Aug 23, 2021
@frankkopp frankkopp mentioned this pull request Aug 23, 2021
Closed
22 tasks
@frankkopp frankkopp requested review from frankkopp and Valastiri and removed request for frankkopp August 25, 2021 12:17
@frankkopp frankkopp mentioned this pull request Aug 26, 2021
Open
56 tasks
@Valastiri
Copy link
Member

Apologies for the double force push. PR should be clean now.

@Valastiri
Copy link
Member

Another fix to bad commit* -force

frankkopp
frankkopp requested changes Sep 1, 2021
View reviewed changes
docs/pilots-corner/a32nx-briefing/.pages Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/altitude-indicator.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/altitude-indicator.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/artificial-horizon.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/artificial-horizon.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/special-message-annunciators.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/speedtape.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/speedtape.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/third-column.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/PFD/third-column.md Outdated Show resolved Hide resolved
@frankkopp
Copy link
Member

@donstim thanks for the review. I will make the changes for this review in this PR: #212
You went over the flight-deck pages which are not part of this PR - this one is dedicated to the PFD section.

@frankkopp
Copy link
Member

@donstim I see now that this PR is also not using the latest flight-deck pages and most of your comments are already addressed in the published version. This is because we did not rebase this PR with the latest version.

Find the published flight-deck pages here: https://docs.flybywiresim.com/pilots-corner/a32nx-briefing/flight-deck/

As written above I'm collection fixes to the flight-deck pages in this PR: #212

BlueberryKing
BlueberryKing reviewed Sep 22, 2021
View reviewed changes
Copy link
Member

@BlueberryKing BlueberryKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just have some small suggestions.

docs/pilots-corner/a32nx-briefing/pfd/speedtape.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/pfd/speedtape.md Outdated Show resolved Hide resolved
docs/pilots-corner/a32nx-briefing/pfd/speedtape.md Outdated Show resolved Hide resolved
@donstim
Copy link

donstim commented Sep 22, 2021

@donstim thanks for the review. I will make the changes for this review in this PR: #212
You went over the flight-deck pages which are not part of this PR - this one is dedicated to the PFD section.

Sorry about that. I just started going through the files and didn't pay proper attention to what this PR was about. Disregard!

@frankkopp
Copy link
Member

Great work! I just have some small suggestions.

Thanks for the review :)

@oim1 @Valastiri
completed PDF
0d4453f 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
@frankkopp frankkopp merged commit a716b74 into flybywiresim:primary Sep 23, 2021
frankkopp referenced this pull request in Valastiri/docs Sep 24, 2021
@oim1 @frankkopp
completed PDF (#177)
bedaa9d 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
frankkopp pushed a commit to frankkopp/flybywire-docs that referenced this pull request Sep 24, 2021
@oim1 @frankkopp
completed PDF (flybywiresim#177)
6757c78 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
frankkopp pushed a commit to frankkopp/flybywire-docs that referenced this pull request Sep 24, 2021
@oim1 @frankkopp
completed PDF (flybywiresim#177)
21cd72a 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
This was referenced Oct 10, 2021
Closed
Merged
frankkopp pushed a commit that referenced this pull request Oct 23, 2021
@oim1 @frankkopp
completed PDF (#177)
ef5af04 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
frankkopp pushed a commit that referenced this pull request Oct 31, 2021
@oim1 @frankkopp
completed PDF (#177)
8cf7c09 
PFD Briefing Page

feat: flight mode annuciator pages and general PFD page

fix: fixed button links

proper button link fix

button fix

added .md to the end of links

feat: added interactive PFD and the rest of the content

Corrected filenames (lowercase)

added recommended changes

Fixed missing nav entry and made PFD folder name lowercase

change pfd .pages title to PFD

add trailing extra pages to pfd .pages

Complete review with fixes and improvements

Optimized images

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Capitalize Mach

Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>

Fixes from review - changed Airspeed headline

Added PFD topic to overview page

Fixed link on Pilot's Corner index page

Improved image for flags-messages.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankkopp frankkopp frankkopp approved these changes

@BlueberryKing BlueberryKing BlueberryKing left review comments

@donstim donstim donstim left review comments

@Valastiri Valastiri Awaiting requested review from Valastiri

Assignees

@oim1 oim1

Labels
a32nx briefing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oim1 @Valastiri @frankkopp @donstim @BlueberryKing