Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a VHDL checker using GHDL #1160

Closed
wants to merge 2 commits into from
Closed

Add a VHDL checker using GHDL #1160

wants to merge 2 commits into from

Conversation

dzamlo
Copy link
Contributor

@dzamlo dzamlo commented Nov 13, 2016

No description provided.

@swsnr
Copy link
Contributor

swsnr commented Nov 14, 2016

@dzamlo Thanks… LGTM, but it will need a couple of refinements.

swsnr
swsnr suggested changes Nov 14, 2016
View reviewed changes
Copy link
Contributor

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note about the new checker to CHANGES.rst.

Could you perhaps also add a test case for the new syntax checker to test/flycheck-test.el? Take a look at the other tests for syntax checkers which are at the end of that file…

flycheck.el
:type '(choice (const :tag "Default standard" nil)
(string :tag "Language standard"))
:safe #'stringp
:package-version '(flycheck . "0.31"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version's wrong here. We do not use a leading zero.

flycheck.el
(flycheck-define-checker vhdl-ghdl
"A VHDL syntax checker using GHDL."
:command ("ghdl"
"-s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's -s for? Could you add comment to the source that explains the purpose of the flag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the flag to do the Syntax-check.

flycheck.el
:command ("ghdl"
"-s"
(option "--std=" flycheck-ghdl-language-standard concat)
source)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can GHDL read the source code from standard input?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@swsnr
Copy link
Contributor

swsnr commented Nov 17, 2016

@dzamlo Thanks! Could you please squash all your commits into a single one so that we can merge?

@cpitclaudel
Copy link
Member

LGTM too! Thanks for working on this :)

@dzamlo
Copy link
Contributor Author

dzamlo commented Nov 17, 2016

All my commits have been squashed.

@dzamlo
Copy link
Contributor Author

dzamlo commented Nov 23, 2016

Is there something blocking this pull request ? I thinks that I addressed the requested changes.

@fmdkdd
Copy link
Member

fmdkdd commented Jul 17, 2017

@dzamlo Terribly sorry for the delay. Your PR suffered a bad timing with the maintainer retiring.

We'd still like to merge this! Can you rebase on master so we can proceed?

@fmdkdd fmdkdd mentioned this pull request Feb 10, 2018
Merged
@fmdkdd
Copy link
Member

fmdkdd commented Feb 10, 2018

Closing in favor of #1399.

@fmdkdd fmdkdd closed this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swsnr swsnr swsnr requested changes

Assignees
No one assigned
Labels
component: checkers status: pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzamlo @swsnr @cpitclaudel @fmdkdd