Fix haskell-module-re to exclude following paren #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is legal and not overly uncommon in haskell to start a module with:
module Foo.Bar(
quux,
baz) where
That is, the module name can be terminated with an open paren as well as with a space.
|
Oh what a blunder of mine; thank you very much for finding and fixing this. 😔 Would you mind to add a test case for this to |
swsnr
pushed a commit
that referenced
this pull request
Jan 10, 2016
It is legal and not overly uncommon in haskell to start a module with:
module Foo.Bar(
quux,
baz) where
That is, the module name can be terminated with an open paren as well as
with a space.
Closes GH-848
|
@fizbin I've merged your patch. Thank you very much! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is legal and not overly uncommon in haskell to start a module with:
That is, the module name can be terminated with an open paren as well as with a space.