Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd unit config checker #1136

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Conversation

holomorph
Copy link
Contributor

adds a checker and entry in languages.rst for a systemd unit config checker using systemd-analyze. see #1135

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2016

CLA assistant check
All committers have signed the CLA.

@manuel-uberti
Copy link
Contributor

Thanks for the PR. :-)

@swsnr
Copy link
Contributor

swsnr commented Oct 17, 2016

@holomorph Please sign the CLA. We're not able to accept your contribution otherwise.

Copy link
Contributor

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits and add Fixes GH-1135 to the commit message so that Github automatically closes that issue if we merge this pull request.

Thanks :)

@holomorph
Copy link
Contributor Author

boom

Copy link
Contributor

@swsnr swsnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just add a entry to the "New syntax checkers" section of CHANGES.rst?

And might we ask you to write an integration test for the syntax checkers in test/flycheck-test.el? Starting from the end of the file there are tests for the other syntax checkers as well, which serve as an example. Any simple test would suffice.

@holomorph holomorph force-pushed the systemd-analyze branch 2 times, most recently from 8cff7d7 to 3c5b0db Compare October 18, 2016 19:19
@holomorph
Copy link
Contributor Author

@lunaryorn done

@swsnr
Copy link
Contributor

swsnr commented Oct 18, 2016

LGTM

.. syntax-checker:: systemd-analyze

Check systemd unit configuration file syntax with
`systemd-analyze <https://www.freedesktop.org/software/systemd/man/systemd-analyze.html>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you turn this into a "named" link? e.g.

`systemd-analyze`_

.. _systemd-analyze: https://…

It's easier to read in plain text form that way.

Don't forget to refill the paragraph afterwards with M-q.

@holomorph
Copy link
Contributor Author

@lunaryorn done

@swsnr swsnr merged commit cf558d0 into flycheck:master Oct 18, 2016
@swsnr
Copy link
Contributor

swsnr commented Oct 18, 2016

@holomorph Thanks a lot, merged!

@cpitclaudel
Copy link
Member

@holomorph Congrats on this contribution!

@manuel-uberti
Copy link
Contributor

@holomorph great stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants