-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemd unit config checker #1136
Conversation
Thanks for the PR. :-) |
@holomorph Please sign the CLA. We're not able to accept your contribution otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your commits and add Fixes GH-1135
to the commit message so that Github automatically closes that issue if we merge this pull request.
Thanks :)
24c6106
to
0a6e577
Compare
boom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you just add a entry to the "New syntax checkers" section of CHANGES.rst
?
And might we ask you to write an integration test for the syntax checkers in test/flycheck-test.el
? Starting from the end of the file there are tests for the other syntax checkers as well, which serve as an example. Any simple test would suffice.
8cff7d7
to
3c5b0db
Compare
@lunaryorn done |
LGTM |
.. syntax-checker:: systemd-analyze | ||
|
||
Check systemd unit configuration file syntax with | ||
`systemd-analyze <https://www.freedesktop.org/software/systemd/man/systemd-analyze.html>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you turn this into a "named" link? e.g.
`systemd-analyze`_
.. _systemd-analyze: https://…
It's easier to read in plain text form that way.
Don't forget to refill the paragraph afterwards with M-q
.
3c5b0db
to
37954d9
Compare
@lunaryorn done |
@holomorph Thanks a lot, merged! |
@holomorph Congrats on this contribution! |
@holomorph great stuff, thanks! |
adds a checker and entry in languages.rst for a systemd unit config checker using systemd-analyze. see #1135