Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -lang en flag to tidy #1445

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Conversation

fmdkdd
Copy link
Member

@fmdkdd fmdkdd commented Apr 9, 2018

Localized error messages also localize the diagnostic
type (e.g. "Warning" becomes "Avertissement" in French), which make them
unparseable by Flycheck.

Forcing English messages makes Flycheck parse the diagnostic correctly,
at the cost of losing the localization.

This is a partial fix for GH-1376.

Localized error messages also localize the diagnostic
type (e.g. "Warning" becomes "Avertissement" in French), which make them
unparseable by Flycheck.

Forcing English messages makes Flycheck parse the diagnostic correctly,
at the cost of losing the localization.

This is a partial fix for GH-1376.
@fmdkdd fmdkdd requested a review from cpitclaudel April 12, 2018 14:14
Copy link
Member

@cpitclaudel cpitclaudel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@fmdkdd fmdkdd merged commit 66ac139 into master Apr 12, 2018
@fmdkdd fmdkdd deleted the fix-1376-localized-tidy-fails-to-parse branch April 12, 2018 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants