Fix caller path in the case of nil #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Thread::Backtrace::Location#absolute_path` can return nil so it would raise exception NoMethodError with `include?` when it returns nil.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated bullet to 5.6.0 at own project, but we have received below exception.
According to the source code of Ruby,
Thread::Backtrace::Location#absolute_pathseems to be able to returnnil. It would become raisingNoMethodErroratinclude?. I could not find the procedure for reproducing clearly because I'm not familiar with Ruby core.We would be able to deal with it by using
to_sto convert fromnilto empty string.