-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/reduce gc pressure, massive speed improvements in benchmark (if Bullet.enable) #42
Merged
flyerhzm
merged 21 commits into
flyerhzm:master
from
riffraff:features/reduce_gc_pressure
May 28, 2011
Merged
Features/reduce gc pressure, massive speed improvements in benchmark (if Bullet.enable) #42
flyerhzm
merged 21 commits into
flyerhzm:master
from
riffraff:features/reduce_gc_pressure
May 28, 2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er page, which causes the GC to happen a lot. change to perform the check without creating such string (though caller is still slow)
…e earliest line of rakefile
Thanks man, I will try it this weekend. |
flyerhzm
added a commit
that referenced
this pull request
May 28, 2011
Features/reduce gc pressure, massive speed improvements in benchmark (if Bullet.enable)
flyerhzm
added a commit
that referenced
this pull request
Jun 1, 2013
Features/reduce gc pressure, massive speed improvements in benchmark (if Bullet.enable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes a few changes to reduce object allocation, uses a Set in Registry::Base so that we can avoid uniq calls all the time, moves flatten in a different position so it's not processing all the registry all the time and uses a direct hash access instead of iterating on a hash. Plus a couple spurious fixes.
I also merged and updated performance/benchmark.rb so it enables bullet and uses profiletools.rb.
From my investigation it resulted that bullet code was not being invoked otherwise.
All tests still passing on 1.8 and 1.9, (osx, linux).
Result for 1.8.7, standard code benchmark (profiling enabled)
1.8.7, my branch
On ruby 1.9.3, no perftools (no 1.9.2 at hand sorry), standard code
my branch
I don't understand why some things were done in such a way, so this may break something else.