Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information that redis-sentinel should not be used with redis >= 3.2 #55

Closed
Draiken opened this issue Feb 26, 2015 · 3 comments
Closed

Comments

@Draiken
Copy link

Draiken commented Feb 26, 2015

We've had some problems after upgrading the redis gem while still using the redis-sentinel. It broke the newly added sentinel support on redis-rb 3.2 and didn't raise any errors. We only found out when deploying to production and the redis client was incorrectly attempting to connect to the localhost.

I'd love to see a warning on the readme or something, so this can be avoided by others in the future :)

@phallstrom
Copy link

👍

@Draiken - You find a solution?

@Draiken
Copy link
Author

Draiken commented Mar 4, 2015

Yes, just removed the redis-sentinel gem, since the redis gem now supports it nativelly. Small change to the initial configuration, changing master_name: lala to url: redis://master.

flyerhzm added a commit that referenced this issue Mar 4, 2015
@phallstrom
Copy link

Ah. And if I'd bothered to read more I would have seen this:

https://github.com/redis/redis-rb#sentinel-support

Definitely worth mentioning in this README/wiki somewhere I agree.

tvon added a commit to tvon/redis-sentinel that referenced this issue Sep 3, 2015
redis-rb includes sentinel support, but only if you are using Redis 2.8.x.  If you are stuck on an older version if Redis then you need to use  redis-rb 3.1.x and redis-sentinal.

My edit could probably be worded better.

Related to flyerhzm#55
@Draiken Draiken closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants