Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nth-child condition fix #158

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Conversation

datb-com
Copy link
Contributor

Great to see that flyingsaucer is still being maintained, and now with OpenPDF - excellent!

I found a bug in support for the nth-child CSS condition. This suggested correction aligns to the formal representation and matches Firefox, Safari and Chrome.
See screenshots in the attached for the pre and post flyingsaucer behaviour and the same CSS in browsers.

2019-03-15_07-13-22 flying saucer nth child test

@pbrant pbrant merged commit 3870571 into flyingsaucerproject:master Mar 15, 2019
@pbrant
Copy link
Member

pbrant commented Mar 15, 2019

Thanks! Do you need a release with this change? I'm happy to do one if so, but if not, I'll bundle it into the next one (which, depending on the number of patches submitted, is probably a few months away).

@datb-com
Copy link
Contributor Author

datb-com commented Mar 15, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants