This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
Fix installer userdata #2420
Merged
Fix installer userdata #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented the script from running under /bin/sh Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
If this is not done, the later `touch` in the same script will fail. Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
This line is commented out by default in our VM images so that we have control over the first boot. Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
| if [[ ! -f "${FIRST_BOOT}" ]]; then | ||
| mkdir -p /var/lib/flynn | ||
|
|
||
| if [ ! -f "${FIRST_BOOT}" ]; then |
There was a problem hiding this comment.
Any reason we aren't using /bin/bash? That is the change I would have made rather than this, but I don't think it really matters.
There was a problem hiding this comment.
I don't think there is reason, no. That change could be made in a future patch, I don't think it really impacts anything.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several bugs in the userdata script, currently preventing EC2 installs with the latest release.
/cc @josephglanville