This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
cli: Fix importing mysql databases #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mysqldump --databases flag leads to both CREATE DATABASE and USE statements to be included in the dump. We are setting the --no-create-db to avoid including the CREATE DATABASE statement (the new app will already have a database), but the USE statement remained leading to the following error on import: ``` ERROR 1044 (42000) at line 22: Access denied for user '04f365e0e25e2c63668876c771ff8cf1'@'%' to database 'dcc6f9d2b76880dde63f975c3637df7f' ``` Given we only export one database, and we use the -D flag on import to use a specific database, there seems to be no reason to use the --databases flag. Signed-off-by: Lewis Marshall <lewis@lmars.net>
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysqldump --databases flag leads to both CREATE DATABASE and USE statements to be included in the dump. We are setting the --no-create-db to avoid including the CREATE DATABASE statement (the new app will already have a database), but the USE statement remained leading to the following error on import:
Given we only export one database, and we use the -D flag on import to use a specific database, there seems to be no reason to use the --databases flag.
/cc @josephglanville