This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
controller: Don't include deleted formations in formation stream #2835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schedulers in a cluster restored from a backup were failing to stream formation updates with the following error:
The stream was being closed because the controller was trying to expand deleted formations, hitting
ErrNotFound
when looking up the associated release and returning that to the stream.I have updated the
formation_list_since
query (along with some others) to check fordeleted_at IS NULL
.