Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI debugging #582

Merged
merged 3 commits into from Dec 10, 2014

Conversation

Projects
None yet
2 participants
@lmars
Copy link
Member

commented Dec 10, 2014

Summary of changes:

  • Add logging to the signal test app, as the test sometimes seems to fail even though the app is running
  • Just stop flynn-host rather than killing the instance when removing so logs can be retrieved
  • Dump processes / flynn-host log on all instances in the cluster
  • Dump logs if bootstrapping fails

Closes #563

fmt.Println()
run(exec.Command("flynn-host", "log", id))
if testCluster == nil {
fmt.Println("skipping dumpLogs as testCluster not set")

This comment has been minimized.

Copy link
@titanous

titanous Dec 10, 2014

Member

Is this line necessary?

lmars added some commits Dec 9, 2014

test: Add logging to test/apps/signal
Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Remove docker backend reference
Signed-off-by: Lewis Marshall <lewis@lmars.net>
test: Dump logs from all booted instances
Signed-off-by: Lewis Marshall <lewis@lmars.net>

@lmars lmars force-pushed the test-debug branch from d3d1ac7 to 4f0a786 Dec 10, 2014

@lmars

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2014

@titanous comments addressed, I added a --dump-logs flag

@titanous

This comment has been minimized.

Copy link
Member

commented Dec 10, 2014

LGTM.

lmars added a commit that referenced this pull request Dec 10, 2014

Merge pull request #582 from flynn/test-debug
Improve CI debugging

@lmars lmars merged commit 2e17974 into master Dec 10, 2014

0 of 2 checks passed

continuous-integration/flynn The Flynn CI build failed
Details
continuous-integration/travis-ci The Travis CI build is in progress
Details

@lmars lmars deleted the test-debug branch Dec 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.