This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
simplify httpclient.Stream invocation #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stream := stream.New() | ||
| chanValue := reflect.ValueOf(outputCh) | ||
| stopChanValue := reflect.ValueOf(stream.StopCh) | ||
| msgType := reflect.TypeOf(outputCh).Elem().Elem() |
There was a problem hiding this comment.
Can just call chanValue.Type
warpfork
force-pushed
the
simplify-http-stream-params
branch
from
65556ff
to
0239037
Compare
| @@ -34,7 +33,7 @@ func Stream(res *http.Response, msgFactory func() interface{}, outputCh interfac | |||
| r := bufio.NewReader(res.Body) | |||
| dec := sse.NewDecoder(r) | |||
| for { | |||
| msg := msgFactory() | |||
| msg := reflect.New(msgType).Interface() | |||
There was a problem hiding this comment.
If you save the reflect.Value instead of throwing it away, there's no need for the ValueOf call below.
warpfork
force-pushed
the
simplify-http-stream-params
branch
from
0239037
to
799a2b3
Compare
This makes creating http client streams significantly terser at the cost of a tiny bit more reflection, by automatically producing message objects based on the output channel's element type. Signed-off-by: Eric Myhre <eric@flynn.io>
warpfork
force-pushed
the
simplify-http-stream-params
branch
from
799a2b3
to
2711d61
Compare
|
LGTM |
warpfork
added a commit
that referenced
this pull request
Jan 13, 2015
simplify httpclient.Stream invocation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes creating http client streams significantly terser at the cost of a tiny bit more reflection, by automatically producing message objects based on the output channel's element type.