This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
cli: Adding --remote flag on "flynn create" command #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -y, --yes Skip the confirmation prompt. | ||
| -r, --remote <remote> Name of git remote to delete, empty string for none. [default: flynn] | ||
| -y, --yes Skip the confirmation prompt. | ||
| --app <name> Explicitly set name of app to delete (otherwise found automatically if --remote is not an empty string). |
There was a problem hiding this comment.
There is already a global -a flag, so --app should be redundant.
Signed-off-by: Geovani de Souza <geovanisouza92@gmail.com>
jvatic
force-pushed
the
cli-flynn-create-remote
branch
from
ac94cd0
to
bf1cefb
Compare
This allows deleting apps created via `flynn create --remote <remote>`. Refs e25f3f3 Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
Tests `flynn create --remote <remote>` where `<remote>` is any string other than "flynn". Tests `flynn delete --remote <remote>` where `<remote>` is the string used for `flynn create --remote <remote>`. Tests `flynn delete --remote <remote> --app <name>` where `<remote>` is an empty string and `<name>` is the name of the app. Signed-off-by: Jesse Stuart <jesse@jessestuart.ca>
jvatic
force-pushed
the
cli-flynn-create-remote
branch
from
bf1cefb
to
23757da
Compare
|
@titanous comments addressed |
|
LGTM |
jvatic
added a commit
that referenced
this pull request
Jan 20, 2015
cli: Adding --remote flag on "flynn create" command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #717