This repository has been archived by the owner on Sep 4, 2021. It is now read-only.
all: Fix attach HTTP upgrade protocol #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was not compliant with the HTTP spec,
and broke when the router was refactored. The new protocol dance
looks like:
POST /attach
Connection: upgrade
Upgrade: flynn-attach/0
...
101 Switching Protocols
Connection: upgrade
Upgrade: flynn-attach/0
<attach frames>
Signed-off-by: Jonathan Rudenberg <jonathan@titanous.com>
titanous
force-pushed
the
fix-attach-upgrade
branch
from
9bc65b8
to
44b7aee
Compare
|
LGTM |
titanous
added a commit
that referenced
this pull request
Jan 24, 2015
all: Fix attach HTTP upgrade protocol
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was not compliant with the HTTP spec, and broke when the router was refactored. The new protocol dance looks like: