Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix archive.replacements in goreleaser #109

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

eapolinario
Copy link
Contributor

TL;DR

Similar flyteorg/flytepropeller#586

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: eduardo apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #109 (2e05a29) into master (dfa2c4c) will increase coverage by 1.16%.
The diff coverage is n/a.

❗ Current head 2e05a29 differs from pull request most recent head 96b964a. Consider uploading reports for the commit 96b964a to get more accurate results

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   68.50%   69.67%   +1.16%     
==========================================
  Files          31       31              
  Lines        1667     1385     -282     
==========================================
- Hits         1142      965     -177     
+ Misses        447      342     -105     
  Partials       78       78              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

@eapolinario eapolinario merged commit 5e2512a into master Jul 7, 2023
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants