fix timestamp and duration literal extraction (#218)

* fixed literal extraction for timestamp and duration types - was previously returning protobufs instead of native golang types

Signed-off-by: Daniel Rammer <daniel@union.ai>

* fixed lint error with imports being non-alphabetical

Signed-off-by: Daniel Rammer <daniel@union.ai>

flyteidl/clients/go/coreutils/extract_literal.go

@@ -46,10 +46,10 @@ func ExtractFromLiteral(literal *core.Literal) (interface{}, error) {
 				scalarPrimitiveBoolean := scalarPrimitive.Boolean
 				return scalarPrimitiveBoolean, nil
 			case *core.Primitive_Datetime:
-				scalarPrimitiveDateTime := scalarPrimitive.Datetime
+				scalarPrimitiveDateTime := scalarPrimitive.Datetime.AsTime()
 				return scalarPrimitiveDateTime, nil
 			case *core.Primitive_Duration:
-				scalarPrimitiveDuration := scalarPrimitive.Duration
+				scalarPrimitiveDuration := scalarPrimitive.Duration.AsDuration()
 				return scalarPrimitiveDuration, nil
 			default:
 				return nil, fmt.Errorf("unsupported literal scalar primitive type %T", scalarValue)

flyteidl/clients/go/coreutils/extract_literal_test.go

@@ -5,6 +5,7 @@ package coreutils
 
 import (
 	"testing"
+	"time"
 
 	"github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core"
 
@@ -21,6 +22,24 @@ func TestFetchLiteral(t *testing.T) {
 		assert.Equal(t, "test_string", val)
 	})
 
+	t.Run("Timestamp", func(t *testing.T) {
+		now := time.Now().UTC()
+		lit, err := MakeLiteral(now)
+		assert.NoError(t, err)
+		val, err := ExtractFromLiteral(lit)
+		assert.NoError(t, err)
+		assert.Equal(t, now, val)
+	})
+
+	t.Run("Duration", func(t *testing.T) {
+		duration := time.Second * 10
+		lit, err := MakeLiteral(duration)
+		assert.NoError(t, err)
+		val, err := ExtractFromLiteral(lit)
+		assert.NoError(t, err)
+		assert.Equal(t, duration, val)
+	})
+
 	t.Run("Array", func(t *testing.T) {
 		lit, err := MakeLiteral([]interface{}{1, 2, 3})
 		assert.NoError(t, err)