Skip to content

Commit

Permalink
Address another TODO
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
  • Loading branch information
Tom-Newton committed Dec 15, 2023
1 parent f3d9f7b commit 453a69f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion flytepropeller/pkg/controller/nodes/branch/evaluator.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ func DecideBranch(ctx context.Context, nl executors.NodeLookup, nodeID v1alpha1.
}
nStatus := nl.GetNodeExecutionStatus(ctx, n.GetID())
logger.Infof(ctx, "Branch Setting Node[%v] status to Skipped!", skippedNodeID)
// TODO: What is the impact of always setting clearStateOnAnyTermination=false here?
// We hard code clearStateOnAnyTermination=false because it has no effect when setting phase to
// NodePhaseSkipped. This saves us passing the config all the way down from the nodeExecutor
nStatus.UpdatePhase(v1alpha1.NodePhaseSkipped, v1.Now(), "Branch evaluated to false", false, nil)
}

Expand Down

0 comments on commit 453a69f

Please sign in to comment.