Fixup flytectl (#5309)

* Fix up flytectl

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Rename module and fix references

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Hook up linting and unit tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove boilerplate directory

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Include flytectl in the go-checks gh job

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix a few unit tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix more tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix more tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix graphviz test

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Reorder test in graphviz_test

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove -race from unit tests temporarily

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

.github/workflows/checks.yml

@@ -34,6 +34,7 @@ jobs:
           - flyteadmin
           # TODO(monorepo): Enable lint flytecopilot
           # - flytecopilot
+          - flytectl
           - flyteidl
           - flyteplugins
           - flytepropeller
@@ -53,6 +54,7 @@ jobs:
           - datacatalog
           - flyteadmin
           - flytecopilot
+          - flytectl
           - flyteplugins
           - flytepropeller
           - flytestdlib
@@ -74,7 +76,7 @@ jobs:
     name: Docker Build Images
     uses: ./.github/workflows/component_docker_build.yml
     with:
-       component: ${{ matrix.component }}
+      component: ${{ matrix.component }}
 
   # TODO(monorepo): these tests are broken. They never test an actual change.
   # endtoend:
@@ -113,6 +115,7 @@ jobs:
           - datacatalog
           - flyteadmin
           - flytecopilot
+          - flytectl
           - flytepropeller
     uses: ./.github/workflows/go_generate.yml
     with:

flytectl/.golangci.yml

@@ -28,3 +28,9 @@ linters:
     - unparam
     - unused
     - varcheck
+linters-settings:
+  gci:
+    skip-generated: true
+issues:
+  exclude:
+    - copylocks

flytectl/Makefile

@@ -1,6 +1,8 @@
 export REPOSITORY=flytectl
-include boilerplate/flyte/golang_test_targets/Makefile
-include boilerplate/flyte/precommit/Makefile
+export REPO_ROOT=..
+include ../boilerplate/flyte/docker_build/Makefile
+include ../boilerplate/flyte/golang_test_targets/Makefile
+include ../boilerplate/flyte/end2end/Makefile
 
 GIT_VERSION := $(shell git describe --always --tags)
 GIT_HASH := $(shell git rev-parse --short HEAD)
@@ -38,3 +40,8 @@ test_unit_without_flag:
 	cat coverage.temp.txt  | grep -v "_flags.go" > coverage.txt
 	rm coverage.temp.txt
 	curl -s https://codecov.io/bash > codecov_bash.sh && bash codecov_bash.sh
+
+# TODO - Add the -race flag back
+.PHONY: test_unit
+test_unit:
+	go test -cover ./...

flytectl/README.md

@@ -16,12 +16,12 @@
 </html>
 
 [![Docs](https://readthedocs.org/projects/flytectl/badge/?version=latest&style=plastic)](https://flytectl.rtfd.io)
-[![Current Release](https://img.shields.io/github/release/flyteorg/flytectl.svg)](https://github.com/flyteorg/flytectl/releases/latest)
-![Master](https://github.com/flyteorg/flytectl/workflows/Master/badge.svg)
-[![GoDoc](https://godoc.org/github.com/flyteorg/flytectl?status.svg)](https://pkg.go.dev/mod/github.com/flyteorg/flytectl)
+[![Current Release](https://img.shields.io/github/release/flyteorg/flyte/flytectl.svg)](https://github.com/flyteorg/flytectl/releases/latest)
+![Master](https://github.com/flyteorg/flyte/flytectl/workflows/Master/badge.svg)
+[![GoDoc](https://godoc.org/github.com/flyteorg/flyte/flytectl?status.svg)](https://pkg.go.dev/mod/github.com/flyteorg/flytectl)
 [![License](https://img.shields.io/badge/LICENSE-Apache2.0-ff69b4.svg)](http://www.apache.org/licenses/LICENSE-2.0.html)
-[![CodeCoverage](https://img.shields.io/codecov/c/github/flyteorg/flytectl.svg)](https://codecov.io/gh/flyteorg/flytectl)
-[![Go Report Card](https://goreportcard.com/badge/github.com/flyteorg/flytectl)](https://goreportcard.com/report/github.com/flyteorg/flytectl)
+[![CodeCoverage](https://img.shields.io/codecov/c/github/flyteorg/flyte/flytectl.svg)](https://codecov.io/gh/flyteorg/flytectl)
+[![Go Report Card](https://goreportcard.com/badge/github.com/flyteorg/flyte/flytectl)](https://goreportcard.com/report/github.com/flyteorg/flytectl)
 ![Commit activity](https://img.shields.io/github/commit-activity/w/lyft/flytectl.svg?style=plastic)
 ![Commit since last release](https://img.shields.io/github/commits-since/lyft/flytectl/latest.svg?style=plastic)
 [![Slack](https://img.shields.io/badge/slack-join_chat-white.svg?logo=slack&style=social)](https://slack.flyte.org)