Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional input types in the Launch UI #22

Closed
georgesnelling opened this issue Nov 19, 2019 · 5 comments
Closed

Support additional input types in the Launch UI #22

georgesnelling opened this issue Nov 19, 2019 · 5 comments
Assignees
Labels
spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface
Milestone

Comments

@georgesnelling
Copy link
Contributor

We don't currently support list/map or some of the less common types. This task is to at least implement list/map and explore if there is anything we can do about supporting the other types.

@schottra
Copy link
Contributor

schottra commented Jan 8, 2020

This issue originally included implementation of collections. Since collections are more commonly used, they were implemented first. The remaining types are a lower priority, so I've updated the description and labels to reflect that.

@kumare3
Copy link
Contributor

kumare3 commented Mar 31, 2020

@schottra I think Launch is very highly used and hence having the breadth covered is probably very important.

@kumare3 kumare3 modified the milestones: 0.2.0, 0.3.0 Mar 31, 2020
@EngHabu EngHabu modified the milestones: 0.3.0, 0.4.0 Apr 30, 2020
@kumare3 kumare3 modified the milestones: 0.4.0, 0.5.0 May 28, 2020
@EngHabu EngHabu removed this from the 0.5.0 milestone Jun 25, 2020
@schottra schottra removed the pri3 label Jul 6, 2020
@schottra schottra added this to the 0.7.0 milestone Jul 6, 2020
@schottra schottra added the spec-first This issue needs a spec to be created and then work. It should be an independent stream label Jul 6, 2020
@EngHabu EngHabu modified the milestones: 0.7.0, 0.8.0 Aug 5, 2020
@EngHabu EngHabu modified the milestones: 0.7.0, 0.8.0 Aug 12, 2020
@kumare3
Copy link
Contributor

kumare3 commented Sep 2, 2020

@schottra do we know which input types are remaining?

@schottra
Copy link
Contributor

schottra commented Sep 8, 2020

@kumare3 Currently, we have no support for:

  • Map
  • Schema
  • Struct
  • Binary (not sure we really plan to support this in any useful way)

We also do not support Error, but I don't expect that to be a type that you can actually accept as an input.

@schottra
Copy link
Contributor

As of flyteconsole v0.17.0, Schema and Struct are now supported. I'm going to create a separate issue for Map and close this one out.
If we want to handle providing Binary values via the console, that should have its own issue as well.

eapolinario referenced this issue in eapolinario/flyte Dec 6, 2022
Adds the `--rm` flag to all the `docker run` commands in generate_protos.sh so you don't end up with pesky exited containers taking up space on your machine.
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
* Flinkk8soperator needs Log writer to be passed to
eapolinario referenced this issue in eapolinario/flyte Dec 20, 2022
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
* Flinkk8soperator needs Log writer to be passed to
eapolinario referenced this issue in eapolinario/flyte Aug 21, 2023
Signed-off-by: Flyte-Bot <admin@flyte.org>

Co-authored-by: flyte-bot <flyte-bot@users.noreply.github.com>
eapolinario pushed a commit that referenced this issue Sep 8, 2023
Adds the `--rm` flag to all the `docker run` commands in generate_protos.sh so you don't end up with pesky exited containers taking up space on your machine.
eapolinario pushed a commit that referenced this issue Sep 12, 2023
eapolinario pushed a commit that referenced this issue Sep 13, 2023
Adds the `--rm` flag to all the `docker run` commands in generate_protos.sh so you don't end up with pesky exited containers taking up space on your machine.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

5 participants