Monorepo flytectl #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exclude generated file from unit test Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: evalsocket <evalsocket@users.noreply.github.com>
* fix sandbox start if sandbox exist Signed-off-by: Yuvraj <code@evalsocket.dev>
* Added node execution data to show inputs and outputs Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Added closure class Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Removed the old wrapper classes Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Uncommented the task exec closure Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Fixed unit tests for the closure classes Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * go mod tidy Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Adding .gitattribute file to contain rule for .rst files Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Adding gen path to .gitattr Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> * Added comments to new structs Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Signed-off-by: Sean Lin <sean@union.ai>
* fix gcp parameters... s3 -> google Signed-off-by: Bruce Arctor <5032356+brucearctor@users.noreply.github.com> * change s3 to google for gcs docs Signed-off-by: Bruce Arctor <5032356+brucearctor@users.noreply.github.com>
Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: kumare3 <kumare3@users.noreply.github.com>
…#150) * Added setup flytedir before config init Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
* code-of-conduct Signed-off-by: Samhita Alla <aallasamhita@gmail.com> * boilerplate Signed-off-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
…un individually (flyteorg#155) Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
Signed-off-by: Sean Lin <sean@union.ai>
* Added k8s check in sandbox * Added upgrade command Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: pmahindrakar-oss <pmahindrakar-oss@users.noreply.github.com>
* Added version compare check and bug fix in sandbox start Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Arnaud Alies <arnaudalies.py@gmail.com>
Signed-off-by: Flyte-Bot <admin@flyte.org> Co-authored-by: evalsocket <evalsocket@users.noreply.github.com>
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Update current video to a shorter version specifically edited to be embedded in the docs.
…flyteorg#168) `flytectl get task/workflow/launchplan -o table` panics if resource has no expected output. We encountered `FormatVariableDescriptions at pkg/printer/printer.go:173` to panic when using the get commands on a resource without expected output. This happened with both explicit table output as well as default. Replicated on lastest master, workflow demo-1.no-output has no expected output: ``` $ go run ./main.go get launchplans -p demo-1 -d production --latest demo-1.no-output panic: assignment to entry in nil map goroutine 1 [running]: github.com/flyteorg/flytectl/pkg/printer.FormatVariableDescriptions(0x0) /workspace/flyteorg/flytectl/pkg/printer/printer.go:202 +0x307 github.com/flyteorg/flytectl/cmd/get.LaunchplanToTableProtoMessages({0xc000a30938, 0x1, 0x7ffeefbff977}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:136 +0xee github.com/flyteorg/flytectl/cmd/get.getLaunchPlanFunc({0x2dfbf98, 0xc0000580b8}, {0xc0002fb8c0, 0x1, 0x11519b4}, {{0x2e55850, 0xc000a30120}, {0x2e472c0, 0xc0009a3110}, {0x2ddff60, ...}, ...}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:158 +0x307 github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000481680, {0xc0002fb8c0, 0x1, 0x6}) /workspace/flyteorg/flytectl/cmd/core/cmd.go:69 +0x47d github.com/spf13/cobra.(*Command).execute(0xc000481680, {0xc0002fb860, 0x6, 0x6}) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0xc000480000) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897 github.com/flyteorg/flytectl/cmd.ExecuteCmd() /workspace/flyteorg/flytectl/cmd/root.go:135 +0x1e main.main() /workspace/flyteorg/flytectl/main.go:12 +0x1d exit status 2 ``` Simple fix: nil checks exists for container but not on the map itself prior to calling, and nil input causes the panic. Added nil check on map parameter prior to calling in all places found. Signed-off-by: Viktor Gerdin <viktorg@spotify.com>
Signed-off-by: Yuvraj <code@evalsocket.dev>
* Added launchplan update command and moved namedentity Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Before, updating some field (i.e. `Description`) of an `Archived` project causes the project state to change to `Active`. This is caused by a bug in the `updateProjectsFunc` function used for the `update` command. During project updates, `edited`, a default project created based on the given configs/flags, comes with `admin.Project_ACTIVE` state by default if both `activate` and `archive` flags have not been set. Then a `copy` of the target project will be updated based on `edited` and then used for showing the diff. In the current implementation, the state of the `copy` is set to be the same as `edited` projects state, which is `Project_ACTIVE` if no flags are set. Also, after showing the diff, the `edited` is used for updating the project. Since it comes with `Project_ACTIVE` state by default, the target project will be updated to have `Project_ACTIVE` if both `activate` and `archive` flags are unset, regardless of the projects previous state. On this PR, we make sure we set the correct state to both `copy` and `edited` by checking if both `activate` and `archive` flags are set/unset. If one of the flags are set, we update target project state (`copy`) based on the `edited` state since it will have the desired state. If both flags are unset, we set the `edited` state to be the same as target (`copy`) state. This way, updating `archived` projects will not change their state. Signed-off-by: mcanueste <mcanueste@gmail.com>
* Misc cleanups to aesthetics Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * make generate Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Fix getting started test Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Fix tests Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Free up space in github runner for getting started test Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Check for pod ready condition instead of just phase Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Fix test Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Add a short sleep for sandbox to be ready to serve requests Signed-off-by: Jeev B <jeevb@users.noreply.github.com> --------- Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
…teorg#440) * Updated Sandbox config, with automated data configuration Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated password Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * updated Signed-off-by: Ketan Umare <ketan.umare@gmail.com> * Fix tests Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Add unit-test Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: Ketan Umare <ketan.umare@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
flyteorg#3458 Include default MinIO credentials in sandbox console readout Signed-off-by: Ruslan Gainanov <gromrx1@gmail.com>
* add monodocs build to ci in flytectl Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * update name Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
* update monodocs build ci with dev build, increase verbosity Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * remove env var Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> --------- Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-CERTIFI-5805047 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
* Rename --archive to --deactivate in update launchplan Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com> * Rename --archive to --deactivate in update launchplan Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com> * Keep --archive as deprecated flag Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com> * make generate Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> --------- Signed-off-by: asoundarya96 <sumisoundarya96@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
* project-archive-with-yaml Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * fix syntax Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * fix list Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> * update generated Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com> --------- Signed-off-by: Peeter Piegaze <1153481+ppiegaze@users.noreply.github.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
…st (flyteorg#450) Signed-off-by: Guy Rapaport <guy4261@gmail.com>
Signed-off-by: nikki everett <nikki@union.ai>
Signed-off-by: troychiu <y.troychiu@gmail.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
* feat: add pagination for get execution (draft) Signed-off-by: zychen5186 <brianchen5197@gmail.com> fix: catches existing commands in os.Args Signed-off-by: zychen5186 <brianchen5197@gmail.com> fix: restore neccessary codes Signed-off-by: zychen5186 <brianchen5197@gmail.com> * feat: use -i to trigger bubbletea, add pagination for get execution Signed-off-by: zychen5186 <brianchen5197@gmail.com> * change dot to arabic paging format Signed-off-by: zychen5186 <brianchen5197@gmail.com> change dot to arabic paging format Signed-off-by: zychen5186 <brianchen5197@gmail.com> change var names Signed-off-by: zychen5186 <brianchen5197@gmail.com> fix: lint Signed-off-by: zychen5186 <brianchen5197@gmail.com> * reuse JSONToTable Signed-off-by: zychen5186 <brianchen5197@gmail.com> * reuse JSONToTable Signed-off-by: zychen5186 <brianchen5197@gmail.com> change := to var Signed-off-by: zychen5186 <brianchen5197@gmail.com> * keep original format when not using bubbletea Signed-off-by: zychen5186 <brianchen5197@gmail.com> * improve readability and no functionality is changed Signed-off-by: zychen5186 <brianchen5197@gmail.com> --------- Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-CERTIFI-3164749 - https://snyk.io/vuln/SNYK-PYTHON-CERTIFI-5805047 - https://snyk.io/vuln/SNYK-PYTHON-JINJA2-6150717 - https://snyk.io/vuln/SNYK-PYTHON-PYGMENTS-1086606 - https://snyk.io/vuln/SNYK-PYTHON-PYGMENTS-1088505 - https://snyk.io/vuln/SNYK-PYTHON-PYGMENTS-5750273 - https://snyk.io/vuln/SNYK-PYTHON-REQUESTS-5595532 - https://snyk.io/vuln/SNYK-PYTHON-SETUPTOOLS-3180412 - https://snyk.io/vuln/SNYK-PYTHON-SPHINX-570772 - https://snyk.io/vuln/SNYK-PYTHON-SPHINX-570773 - https://snyk.io/vuln/SNYK-PYTHON-SPHINX-5811865 - https://snyk.io/vuln/SNYK-PYTHON-SPHINX-5812109 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link