Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Cache Flyte deck #2603

Open
2 tasks done
pingsutw opened this issue Jun 9, 2022 · 4 comments
Open
2 tasks done

[Core feature] Cache Flyte deck #2603

pingsutw opened this issue Jun 9, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request flytepropeller propeller Issues related to flyte propeller stale

Comments

@pingsutw
Copy link
Member

pingsutw commented Jun 9, 2022

Motivation: Why do you think this is important?

We should cache flyte deck in execution, otherwise, FlyteConsole won't display the deck file when the cache is hit

To cache the deck file, we can add deck_uri to the new artifact in datacatalog. Therefore, every time we cache the task execution, we'll create two artifacts. one for output literal, another one for deck_uri.

check more detail here, flyteorg/flytepropeller#443 (comment)

Goal: What should the final outcome look like, ideally?

We can get the deck file from node execution when the cache is hit.

Describe alternatives you've considered

No

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@pingsutw pingsutw added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers propeller Issues related to flyte propeller flytepropeller and removed untriaged This issues has not yet been looked at by the Maintainers labels Jun 9, 2022
@wild-endeavor wild-endeavor added this to the 1.3.0 milestone Jul 22, 2022
@hamersaw
Copy link
Contributor

hamersaw commented Nov 1, 2022

I am having trouble wrapping my head around this. In the previous PR you mentioned it sounds like we wanted to add another artifact to the dataset in the catalog for flytedecks. I don't see that happening anywhere, am I missing this?

These PRs seems to assume that the artifact has a metadata item attached to it for the "deckURI" - this is an alternative approach right?

@eapolinario eapolinario removed this from the 1.3.0 milestone Jan 13, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Oct 11, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Copy link

github-actions bot commented Aug 1, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytepropeller propeller Issues related to flyte propeller stale
Projects
None yet
Development

No branches or pull requests

4 participants