Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: alb.ingress.kubernetes.io/target-type: 'ip' in the ingress annotation of value-eks.yaml #2743

Open
brucearctor opened this issue Aug 8, 2022 · 9 comments
Labels

Comments

@brucearctor
Copy link
Contributor

This breaks the https://docs.flyte.org/en/latest/deployment/aws/manual.html#connecting-to-flyte

Now we will have to add: alb.ingress.kubernetes.io/target-type: 'ip' in the ingress annotation of value-eks.yaml

@brucearctor
@EngHabu

RE: #2566
Originally posted by @jw0515 in #2566 (comment)

@brucearctor
Copy link
Contributor Author

Not sure whether needed, but made an issue - due to @jw0515's comment, as seems to warrant exploration.

@jw0515
Copy link
Contributor

jw0515 commented Aug 8, 2022

By default the alb.ingress.kubernetes.io/target-type will be "instance" which only works for NodePort/LoadBalancer type:
kubernetes-sigs/aws-load-balancer-controller#1695

@brucearctor
Copy link
Contributor Author

brucearctor commented Aug 8, 2022

@jw0515 -- I can't explore this. Requires cloud compute resources ( AWS ), and that hasn't been set up for the Open Source project. There is only cloud resources and testing infra for Union employees. I don't want pay out of pocket for such cloud spend, so I'm not working on these sorts of things. I imagine that @EngHabu and team can take a look eventually.

Strong testing of the deployment guides to ensure nothing breaks with updates/changes is pretty critical.

@jw0515
Copy link
Contributor

jw0515 commented Aug 8, 2022

Makes sense!

@alexifm
Copy link

alexifm commented Dec 19, 2022

Hi, I went through the AWS deployment guide last night. I ran into this error and it's not at all the clearest thing to figure out what's wrong.

There were a few things I adjusted in the values file but admittedly, that's because I didn't go through the guide exactly as stated. I made some tweaks here and there that broke compatibility with the values file. Happy to offer some suggestions.

@pmahindrakar-oss
Copy link
Contributor

@alexifm would be great if you can help with adding what you changed in this issue which can eventually we can followup with doc changes or values files changes.

@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Sep 16, 2023
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
@eapolinario eapolinario reopened this Nov 2, 2023
@github-actions github-actions bot removed the stale label Nov 4, 2023
Copy link

github-actions bot commented Aug 1, 2024

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants