Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytekit-java] Change SdkBindingData to be typed #3250

Closed
2 tasks done
andresgomezfrr opened this issue Jan 20, 2023 · 1 comment
Closed
2 tasks done

[flytekit-java] Change SdkBindingData to be typed #3250

andresgomezfrr opened this issue Jan 20, 2023 · 1 comment
Labels
enhancement New feature or request flytekit-java Flytekit Java related issue

Comments

@andresgomezfrr
Copy link
Contributor

Motivation: Why do you think this is important?

After evaluating the current development experience using flytekit-java with some of our users. We've detected some improvements that could help to do the development experience more smooth. One of them is the difficulty that the users have to know what is the specific type of SdkBindingData when working with remote tasks. Currently, the user needs to jump into the remote code to check the input/output classes to know what is the specific type of each attribute. It could be very tedious because you need to find the repository of this remote task or jump using the IDE and check the input.

Goal: What should the final outcome look like, ideally?

The final outcome is that we want to change the SdkBindingData to a typed version SdkBindingData<?>. This new version allows the user to know the inner type during the normal development and also helps to ensure that you are setting the current input to a task because if not you get a type mismatch error at compile time.

Describe alternatives you've considered

no alternatives

Propose: Link/Inline OR Additional context

flyteorg/flytekit-java#164

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@andresgomezfrr andresgomezfrr added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jan 20, 2023
@narape narape added flytekit-java Flytekit Java related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 20, 2023
@narape narape closed this as completed Jan 24, 2023
@narape
Copy link
Collaborator

narape commented Jan 24, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit-java Flytekit Java related issue
Projects
None yet
Development

No branches or pull requests

2 participants