Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dev environment cannot be installed on Mac M1's #3264

Closed
2 tasks done
eapolinario opened this issue Jan 25, 2023 · 1 comment
Closed
2 tasks done

[BUG] dev environment cannot be installed on Mac M1's #3264

eapolinario opened this issue Jan 25, 2023 · 1 comment
Assignees
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Milestone

Comments

@eapolinario
Copy link
Contributor

eapolinario commented Jan 25, 2023

Describe the bug

The contributor guide specifies that users should run make setup as part of the dev environment, however that command fails on Mac M1's with this error message:

ERROR: Ignored the following versions that require a different python version: 2.6.2 Requires-Python >=3.6, <3.9
ERROR: Could not find a version that satisfies the requirement tensorflow-io-gcs-filesystem==0.28.0 (from versions: none)
ERROR: No matching distribution found for tensorflow-io-gcs-filesystem==0.28.0

and

ERROR: No matching distribution found for tensorflow==2.8.1

The issue stems from the fact that tensorflow special-cases a dependency based on the platform+OS, while we currently only maintain a single set of requirements files.

Expected behavior

Mac M1's users should be able to run make setup successfully.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@eapolinario eapolinario added bug Something isn't working flytekit FlyteKit Python related issue labels Jan 25, 2023
@eapolinario eapolinario added this to the 1.4.0 milestone Jan 25, 2023
@eapolinario eapolinario self-assigned this Jan 25, 2023
@eapolinario
Copy link
Contributor Author

With flyteorg/flytekit@99d3d50 we made it so that the dev environment works again on M1's. The one caveat is that tensorflow doesn't install cleanly on M1's yet, so those unit tests will not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant