Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Detect if running on a Mac M1 and use appropriate dev-requirements file #1424

Closed
wants to merge 4 commits into from

Conversation

eapolinario
Copy link
Collaborator

@eapolinario eapolinario commented Jan 25, 2023

Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com

Fixes flyteorg/flyte#3264

TL;DR

Special case Mac M1/2's in the case of dev environment

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

In this PR the make targets related to the dev environment detect if the user's platform. We introduce a new dev-requirements file produced on a Mac M1.

Testing:

  • need someone to run make dev-requirements.txt on a M1 and push a commit to this PR with the contents of the dev-requirements-mac_arm64.txt file.
  • run make setup on a new venv

Tracking Issue

flyteorg/flyte#3264

Follow-up issue

NA

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #1424 (d345c63) into master (5dd887c) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
+ Coverage   69.20%   69.24%   +0.03%     
==========================================
  Files         300      300              
  Lines       28114    28146      +32     
  Branches     2646     2649       +3     
==========================================
+ Hits        19457    19490      +33     
+ Misses       8143     8142       -1     
  Partials      514      514              
Impacted Files Coverage Δ
flytekit/extras/sqlite3/task.py 90.74% <0.00%> (-0.17%) ⬇️
flytekit/core/promise.py 52.70% <0.00%> (ø)
tests/flytekit/unit/bin/test_python_entrypoint.py 99.55% <0.00%> (+0.04%) ⬆️
tests/flytekit/unit/remote/test_lazy_entity.py 92.45% <0.00%> (+1.54%) ⬆️
flytekit/remote/lazy_entity.py 97.43% <0.00%> (+2.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eapolinario eapolinario changed the title Detect if running on a Mac M1 and use appropriate dev-requirements file WIP - Detect if running on a Mac M1 and use appropriate dev-requirements file Jan 25, 2023
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario
Copy link
Collaborator Author

Superseded by #1511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant