[Feature] Allow no-prefix flags #341
Assignees
Labels
Comments
EngHabu
added
enhancement
kumare3
removed
the
untriaged
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 6, 2022
* moved events to top-level and merged with flyteidl events Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed events imports on tests Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * added error message length validation and truncating if necessary. Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * added admin event error message truncating Signed-off-by: Daniel Rammer <daniel@union.ai> * began adding oppo bloom filter to admin event sink Signed-off-by: Daniel Rammer <daniel@union.ai> * removed truncating error message - didn't actually fix anything Signed-off-by: Daniel Rammer <daniel@union.ai> * added oppobloom filter to admin event sink Signed-off-by: Daniel Rammer <daniel@union.ai> * moved EventRecorder and EventSink mocks to the mocks package Signed-off-by: Daniel Rammer <daniel@union.ai> * updated tests to use fastcheck.Filter mock Signed-off-by: Daniel Rammer <daniel@union.ai> * resolved merge conflicts with go.mod and go.sum Signed-off-by: Daniel Rammer <daniel@union.ai> * moved idFromMessage to separate func Signed-off-by: Daniel Rammer <daniel@union.ai> * updated go.mod with newest flytestdlib version to include filter mocks Signed-off-by: Daniel Rammer <daniel@union.ai> * added another level of prometheus scope to better clarify metric Signed-off-by: Daniel Rammer <daniel@union.ai> * exported IDFromMessage and added explicit unit tests for it Signed-off-by: Daniel Rammer <daniel@union.ai> * added comment on IDFromMessage function Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Dec 20, 2022
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Jul 24, 2023
…#341) * wip Signed-off-by: byhsu <byhsu@linkedin.com> * add comment Signed-off-by: byhsu <byhsu@linkedin.com> * more comment Signed-off-by: byhsu <byhsu@linkedin.com> * fix style Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 9, 2023
* moved events to top-level and merged with flyteidl events Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed events imports on tests Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * added error message length validation and truncating if necessary. Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed lint issues Signed-off-by: Daniel Rammer <daniel@union.ai> * added admin event error message truncating Signed-off-by: Daniel Rammer <daniel@union.ai> * began adding oppo bloom filter to admin event sink Signed-off-by: Daniel Rammer <daniel@union.ai> * removed truncating error message - didn't actually fix anything Signed-off-by: Daniel Rammer <daniel@union.ai> * added oppobloom filter to admin event sink Signed-off-by: Daniel Rammer <daniel@union.ai> * moved EventRecorder and EventSink mocks to the mocks package Signed-off-by: Daniel Rammer <daniel@union.ai> * updated tests to use fastcheck.Filter mock Signed-off-by: Daniel Rammer <daniel@union.ai> * resolved merge conflicts with go.mod and go.sum Signed-off-by: Daniel Rammer <daniel@union.ai> * moved idFromMessage to separate func Signed-off-by: Daniel Rammer <daniel@union.ai> * updated go.mod with newest flytestdlib version to include filter mocks Signed-off-by: Daniel Rammer <daniel@union.ai> * added another level of prometheus scope to better clarify metric Signed-off-by: Daniel Rammer <daniel@union.ai> * exported IDFromMessage and added explicit unit tests for it Signed-off-by: Daniel Rammer <daniel@union.ai> * added comment on IDFromMessage function Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Aug 21, 2023
…#341) * wip Signed-off-by: byhsu <byhsu@linkedin.com> * add comment Signed-off-by: byhsu <byhsu@linkedin.com> * more comment Signed-off-by: byhsu <byhsu@linkedin.com> * fix style Signed-off-by: byhsu <byhsu@linkedin.com> --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
|
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
|
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this issue
Apr 30, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this issue
May 7, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this issue
Jul 2, 2024
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
troychiu
pushed a commit
that referenced
this issue
Jul 8, 2024
## Overview This PR adds components to ensure each Actor Environment is unique. The attribute list is org, project, domain, a user provided ID, and an auto-generate version hash. ## Test Plan This will be tested locally under a variety of scenarios. This change only affects which fasttasks are executed in each environment, so there is no need for testing on Union. ## Rollout Plan (if applicable) Once validated this update may be deployed to all tenants immediately. ## Upstream Changes Should this change be upstreamed to OSS (flyteorg/flyte)? If not, please uncheck this box, which is used for auditing. Note, it is the responsibility of each developer to actually upstream their changes. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed to OSS ## Issue https://linear.app/unionai/issue/EXO-110/decide-on-execution-environment-id-uniqueness-for-actor-environments ## Checklist * [ ] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [ ] Updated documentation
|
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation: Why do you think this is important?
When adding config sections using flytestdlib/config, it's inconvenient to require a prefix (section name) for all Pflags added.
Goal: What should the final outcome look like, ideally?
Allow the root-level flag section to be specified without a prefix.
E.g.
myCmd --optioninstead ofmyCmd --root.optionFlyte component
The text was updated successfully, but these errors were encountered: