use values.yaml when testing for postgres readiness

[ajsalow]

Signed-off-by: ajsalow ajsalow@umich.edu

Close #1142

[welcome]

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

[kumare3]

Thank you

[pmahindrakar-oss]

nit : Values.db.database.host

[ajsalow]

Looks like the test is failing because neither values-gcp.yaml or values.yaml specify a database config. This causes the helm output to have until pg_isready -h -p ; do echo waiting for database; sleep 2; done; instead of until pg_isready -h postgres -p 5432; do echo waiting for database; sleep 2; done;. Let me know if you want me to update one of values files to contain the default db config.

[sbrunk]

@ajsalow the test fails because you need to run make helm and push the generated manifests to git.

Background:
make helm runs https://github.com/flyteorg/flyte/blob/master/script/generate_helm.sh which will generate manifests for
values-sandbox.yaml, values-aws.yaml and values-gcp.yaml (not for the default values.yaml).
Don't worry about the broken gcp config, it's not finished yet.

[sbrunk]

Sorry @ajsalow could you rebase against master and re-run make helm to resolve the conflict? Also could you make sure to use helm 3.6 because it formats some lines diffently, otherwise the test is going to fail again.

[ajsalow]

@sbrunk Thanks for the help. Hopefully it is good to go now!

[sbrunk]

Looks good to me. LGTM!

[welcome]

Congrats on merging your first pull request! 🎉