Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order clusterresourcesync annotations #2542

Merged
merged 1 commit into from
May 25, 2022
Merged

Re-order clusterresourcesync annotations #2542

merged 1 commit into from
May 25, 2022

Conversation

bstadlbauer
Copy link
Member

This is done as otherwise we would get a <.Template.BasePath>: nil pointer evaluating interface {}.BasePath error when setting e.g.:

cluster_resource_manager:
  podAnnotations:
    foo: bar

Signed-off-by: Bernhard Stadlbauer 11799671+bstadlbauer@users.noreply.github.com

@bstadlbauer
Re-order clusterresourcesync annotations
68f5fd4 
This is done as otherwise you'd get a ` <.Template.BasePath>: nil pointer evaluating interface {}.BasePath` error

Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com>
@bstadlbauer bstadlbauer mentioned this pull request May 25, 2022
Merged
@bstadlbauer bstadlbauer requested a review from yindia May 25, 2022 10:44
yindia
yindia approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@yindia yindia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yindia yindia merged commit 5f1b452 into flyteorg:master May 25, 2022
@bstadlbauer
Copy link
Member Author

@evalsocket Thank you for the quick turnaround on this!
Would it be much of an effort to release 1.0.2-b2?

@yindia
Copy link
Contributor

yindia commented May 25, 2022

No i am planning it tomorrow itself

@yindia
Copy link
Contributor

yindia commented May 26, 2022

@bstadlbauer https://github.com/flyteorg/flyte/releases/tag/v1.0.2-b2

@bstadlbauer
Copy link
Member Author

@evalsocket Thank you very much! Things are up and running on our side 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yindia yindia yindia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bstadlbauer @yindia