Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated flyte-sandbox-bundled helm chart #3066

Merged
merged 9 commits into from Nov 15, 2022

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Nov 12, 2022

Squashed from: #3054

Related to: #2993

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb force-pushed the jeev/flyte-sandbox-chart-build branch 3 times, most recently from b22a2c8 to c8e0378 Compare November 12, 2022 16:46
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb force-pushed the jeev/flyte-sandbox-chart-build branch from c8e0378 to 1a96b18 Compare November 12, 2022 16:54
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb force-pushed the jeev/flyte-sandbox-chart-build branch from b0b0dca to b072732 Compare November 12, 2022 20:37
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb force-pushed the jeev/flyte-sandbox-chart-build branch from a631f79 to 44d6362 Compare November 14, 2022 19:28
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need both compiled.yaml and bootstrap/output.yaml

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb marked this pull request as ready for review November 15, 2022 02:19
wild-endeavor
wild-endeavor previously approved these changes Nov 15, 2022
eapolinario
eapolinario previously approved these changes Nov 15, 2022
Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing.

Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the files under gen/ used anywhere? can we just delete all of them?

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb dismissed stale reviews from eapolinario and wild-endeavor via f755c96 November 15, 2022 17:14
@wild-endeavor wild-endeavor merged commit 9f9e5c2 into master Nov 15, 2022
@wild-endeavor wild-endeavor deleted the jeev/flyte-sandbox-chart-build branch November 15, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants