Expose sandbox node ports for Minio and Postgres #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
changed the title
EngHabu
approved these changes
May 13, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
…teorg#310) * bump flytepropeller version to include flyteworkflow crd labels Signed-off-by: Daniel Rammer <daniel@union.ai> * remove go mod tidy in Dockerfile Signed-off-by: Daniel Rammer <daniel@union.ai> * go mod tidy with v1.17 Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
Signed-off-by: SandraGH5 <sandra@union.ai> Co-authored-by: SandraGH5 <sandra@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Jul 24, 2023
* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * transition to failed state if task isn't created Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fix Signed-off-by: Kevin Su <pingsutw@apache.org> * fix Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 9, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
…teorg#310) * bump flytepropeller version to include flyteworkflow crd labels Signed-off-by: Daniel Rammer <daniel@union.ai> * remove go mod tidy in Dockerfile Signed-off-by: Daniel Rammer <daniel@union.ai> * go mod tidy with v1.17 Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
* wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * transition to failed state if task isn't created Signed-off-by: Kevin Su <pingsutw@apache.org> * wip Signed-off-by: Kevin Su <pingsutw@apache.org> * nit Signed-off-by: Kevin Su <pingsutw@apache.org> * fix Signed-off-by: Kevin Su <pingsutw@apache.org> * fix Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing Flyte, it is necessary often to run both Propeller and Admin from the contributor's laptop (from Goland for instance). In these cases, contributors currently need to port forward each of Minio and Postgres in order to do so.
This exposes 30083 for the sandbox Postgres instance and 30084 for Minio, thereby making port forwarding no longer necessary.