Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Databricks Agent Doc #4008

Merged
merged 30 commits into from
Dec 2, 2023
Merged

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Sep 4, 2023

Describe your changes

Add agent service sample in Web APIs Databricks plugin.
Currently, we can enable flyteagent from flyte using helm.
We want to enable users to deploy the Datbabricks agent through Helm.

Here is the URL: https://flyte--4008.org.readthedocs.build/en/4008/deployment/agents/databricks.html#deployment-agent-setup-databricks

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

image
image
image

Tracking Issue

#3936

Signed-off-by: Future Outlier <eric901201@gmai.com>
@welcome
Copy link

welcome bot commented Sep 4, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier
Copy link
Member Author

@pingsutw Please review, thanks a lot!

rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/webapi/databricks.rst Outdated Show resolved Hide resolved
Future-Outlier and others added 6 commits September 9, 2023 16:20
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier
Copy link
Member Author

@pingsutw Please review, thanks a lot!

Future Outlier added 2 commits September 26, 2023 10:17
Signed-off-by: Future Outlier <eric901201@gmai.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebed2a6) 59.40% compared to head (64b0a54) 59.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
- Coverage   59.40%   59.40%   -0.01%     
==========================================
  Files         638      638              
  Lines       53957    53957              
==========================================
- Hits        32052    32051       -1     
- Misses      19376    19377       +1     
  Partials     2529     2529              
Flag Coverage Δ
unittests 59.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Future Outlier and others added 4 commits October 3, 2023 09:28
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Future-Outlier and others added 2 commits October 10, 2023 20:31
Signed-off-by: Future Outlier <eric901201@gmai.com>
@Future-Outlier Future-Outlier changed the title [Docs] Add Agent Service Doc in Databricks Plugin [Docs] Databricks Agent Doc Oct 10, 2023
Future Outlier added 2 commits October 12, 2023 21:29
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
rsts/deployment/agents/databricks.rst Outdated Show resolved Hide resolved
rsts/deployment/agents/databricks.rst Outdated Show resolved Hide resolved
pingsutw and others added 10 commits November 7, 2023 23:56
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Future Outlier <eric901201@gmai.com>
…flyte into revise-agent-doc

Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 28, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2023
@pingsutw pingsutw enabled auto-merge (squash) December 2, 2023 11:56
@pingsutw pingsutw merged commit 1d334d2 into flyteorg:master Dec 2, 2023
44 of 45 checks passed
neverett added a commit that referenced this pull request Jan 19, 2024
Signed-off-by: nikki everett <nikki@union.ai>
Future-Outlier pushed a commit that referenced this pull request Jan 21, 2024
Signed-off-by: nikki everett <nikki@union.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants