Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from flyteplugins - Sync Plugin Interface #4131

Closed

Conversation

eapolinario
Copy link
Contributor

TL;DR

As title.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

I need maintainers to take a look at whether this implementation is good enough.
Currently, the "core. go" file is not fully completed, but you can take a look at the interface.

Tracking Issue

flyteorg/flyteidl#436
flyteorg/flytekit#1822

Follow-up issue

#3936

Future Outlier and others added 3 commits September 27, 2023 21:42
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d9586b0) 58.98% compared to head (b674d93) 59.54%.

❗ Current head b674d93 differs from pull request most recent head 09112b8. Consider uploading reports for the commit 09112b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4131      +/-   ##
==========================================
+ Coverage   58.98%   59.54%   +0.55%     
==========================================
  Files         619      216     -403     
  Lines       52804    15938   -36866     
==========================================
- Hits        31146     9490   -21656     
+ Misses      19174     5473   -13701     
+ Partials     2484      975    -1509     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 600 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants