Moving from flyteadmin - Upgrade coreos/go-oidc to v3 to pickup claims parsing fixes #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
- Coverage 59.74% 59.74% -0.01%
==========================================
Files 636 636
Lines 53870 53870
==========================================
- Hits 32187 32184 -3
- Misses 19152 19156 +4
+ Partials 2531 2530 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
…pgrade-coreos/go-oidc Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
|
I kicked off a new single-binary image in https://github.com/flyteorg/flyte/actions/runs/6712980653. |
…/flyteadmin/upgrade-coreos/go-oidc
EngHabu
approved these changes
Nov 28, 2023
dosubot
bot
added
the
size:L
eapolinario
deleted the
monorepo-move/flyteadmin/upgrade-coreos/go-oidc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Reference conversation
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/