New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transient secret sync error handling #4310
Fix transient secret sync error handling #4310
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
bfcaae3
to
9aff13b
Compare
c6d51d6
to
30875f5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4310 +/- ##
==========================================
+ Coverage 58.89% 58.90% +0.01%
==========================================
Files 620 620
Lines 52440 52458 +18
==========================================
+ Hits 30883 30901 +18
Misses 19090 19090
Partials 2467 2467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@Tom-Newton this looks great! Could you fix the unit test (should be a string match update) and then I think we're good to merge. You can run these from the root of the repo using |
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
74ab23a
to
cc1a119
Compare
cc1a119
to
7a40d98
Compare
Done
Thanks. I hadn't worked out how to run all tests. |
* Extra logging Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Hopefully fix it Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Remove debug prints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Reduce duplication Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Tidy Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add a test Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Use a CreateContainerConfigErrorGracePeriod Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add grace period to error message Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Retryable failure with cleanup Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Longer grace period Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix test Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Set default grace period to 0 to avoid changing default behaviour Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Update comment Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Use permanent error with clean up Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Don't use cleanup Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix test Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> --------- Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> Co-authored-by: Dan Rammer <daniel@union.ai>
Tracking issue
Closes #4309
Describe your changes
create-container-config-error-grace-period
forCreateContainerConfigError
s similar tocreate-container-error-grace-period
forCreateContainerError
.Check all the applicable boxes
create-container-error-grace-period
I don't think there is anything else I need to do.Screenshots
Note to reviewers