Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to auth scope #4341

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Add comment to auth scope #4341

merged 1 commit into from
Nov 8, 2023

Conversation

wild-endeavor
Copy link
Contributor

following some confusion in OSS slack.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ac4ec7d) 59.07% compared to head (f60dc56) 59.33%.
Report is 3 commits behind head on master.

❗ Current head f60dc56 differs from pull request most recent head 7383037. Consider uploading reports for the commit 7383037 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4341      +/-   ##
==========================================
+ Coverage   59.07%   59.33%   +0.25%     
==========================================
  Files         614      544      -70     
  Lines       52006    38974   -13032     
==========================================
- Hits        30723    23125    -7598     
+ Misses      18832    13571    -5261     
+ Partials     2451     2278     -173     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/auth/token.go 0.00% <ø> (ø)
flyteplugins/go/tasks/plugins/k8s/ray/config.go 36.36% <ø> (+7.79%) ⬆️
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 83.68% <91.93%> (+0.30%) ⬆️

... and 549 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit bec7bbb into master Nov 8, 2023
41 checks passed
@wild-endeavor wild-endeavor deleted the cfg-auth-scope branch November 8, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants