Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RunPluginEndToEndTest util #4342

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

andresgomezfrr
Copy link
Contributor

@andresgomezfrr andresgomezfrr commented Nov 1, 2023

Tracking issue

Closes #4343

Describe your changes

Remove duplicated mock without Run that produces that the output file is not saved to the inmemory store.

time="2023-11-01T10:34:44+01:00" level=error msg="Failed to read from the raw store [fake://bucket/prefix/2g6/outputs.pb] Error: file does not exist"
        	Error:      	Received unexpected error:
        	            	file does not exist
        	            	path:fake://bucket/prefix/2g6/outputs.pb
        	            	github.com/flyteorg/flyte/flytestdlib/storage.DefaultProtobufStore.ReadProtobuf
        	            		/Users/andresg/go/pkg/mod/github.com/flyteorg/flyte/flytestdlib@v1.10.0/storage/protobuf_store.go:39
        	            	github.com/flyteorg/flyte/flyteplugins/tests.RunPluginEndToEndTest
        	            		/Users/andresg/go/pkg/mod/github.com/flyteorg/flyte/flyteplugins@v1.10.0/tests/end_to_end.go:261
....

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Andres Gomez Ferrer <andresg@spotify.com>
Copy link

welcome bot commented Nov 1, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@eapolinario eapolinario merged commit 617e481 into flyteorg:master Nov 1, 2023
39 checks passed
Copy link

welcome bot commented Nov 1, 2023

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicated mock breaks RunPluginEndToEndTest util
2 participants