Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing caching on maptasks when using partials #4344

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Nov 1, 2023

Tracking issue

fixes #4330

Describe your changes

Adding the partial input literals to the static input readers so that they are included in cache key computation.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

NA

Note to reviewers

NA

…computation

Signed-off-by: Daniel Rammer <daniel@union.ai>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ac4ec7d) 59.07% compared to head (68d5a73) 59.35%.
Report is 6 commits behind head on master.

❗ Current head 68d5a73 differs from pull request most recent head 54e65b6. Consider uploading reports for the commit 54e65b6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4344      +/-   ##
==========================================
+ Coverage   59.07%   59.35%   +0.27%     
==========================================
  Files         614      544      -70     
  Lines       52006    38967   -13039     
==========================================
- Hits        30723    23129    -7594     
+ Misses      18832    13559    -5273     
+ Partials     2451     2279     -172     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteplugins/go/tasks/plugins/k8s/ray/config.go 36.36% <ø> (+7.79%) ⬆️
...g/controller/nodes/array/node_execution_context.go 59.25% <0.00%> (-0.07%) ⬇️
flyteplugins/go/tasks/plugins/array/catalog.go 47.71% <75.00%> (+2.41%) ⬆️
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 83.68% <91.93%> (+0.30%) ⬆️

... and 548 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw hamersaw merged commit eccf993 into master Nov 6, 2023
39 checks passed
@hamersaw hamersaw deleted the bug/maptask-partial-cache branch November 6, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Caching does not work correctly for partials
2 participants