Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata in ArrayNode TaskExecutionEvents #4355

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Nov 2, 2023

Tracking issue

NA

Describe your changes

Setting PluginIdentifier and Input and Output values.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

NA

Note to reviewers

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
…eadmin temporarily

Signed-off-by: Daniel Rammer <daniel@union.ai>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (617e481) 59.10% compared to head (b136f97) 59.34%.
Report is 15 commits behind head on master.

❗ Current head b136f97 differs from pull request most recent head a88a4df. Consider uploading reports for the commit a88a4df to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
+ Coverage   59.10%   59.34%   +0.24%     
==========================================
  Files         614      544      -70     
  Lines       52065    39003   -13062     
==========================================
- Hits        30771    23146    -7625     
+ Misses      18844    13575    -5269     
+ Partials     2450     2282     -168     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/auth/token.go 0.00% <ø> (ø)
flyteplugins/go/tasks/logs/logging_utils.go 89.70% <100.00%> (+1.61%) ⬆️
...ns/go/tasks/pluginmachinery/flytek8s/pod_helper.go 75.72% <100.00%> (-2.12%) ⬇️
...ugins/go/tasks/pluginmachinery/tasklog/template.go 98.62% <100.00%> (+0.50%) ⬆️
flyteplugins/go/tasks/plugins/array/core/state.go 69.13% <100.00%> (-2.22%) ⬇️
flyteplugins/go/tasks/plugins/k8s/dask/dask.go 80.93% <100.00%> (+2.62%) ⬆️
flyteplugins/go/tasks/plugins/k8s/spark/spark.go 76.87% <100.00%> (+2.92%) ⬆️
...ller/pkg/controller/nodes/task/taskexec_context.go 80.89% <100.00%> (+1.88%) ⬆️
flyteplugins/go/tasks/plugins/k8s/pod/plugin.go 80.41% <88.88%> (+3.78%) ⬆️
...ugins/go/tasks/plugins/webapi/databricks/plugin.go 65.34% <77.77%> (+3.84%) ⬆️
... and 6 more

... and 536 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw hamersaw marked this pull request as ready for review November 7, 2023 16:52
Signed-off-by: Daniel Rammer <daniel@union.ai>
@@ -120,11 +120,39 @@ func (e *externalResourcesEventRecorder) finalize(ctx context.Context, nCtx inte
OccurredAt: occurredAt,
Metadata: &event.TaskExecutionMetadata{
ExternalResources: e.externalResources,
PluginIdentifier: "container",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: why is not container_array?

@hamersaw hamersaw merged commit dd91cba into master Nov 8, 2023
39 of 41 checks passed
@hamersaw hamersaw deleted the bug/arraynode-metadata-update branch November 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants