Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument opentelemetry #4357

Merged
merged 31 commits into from
Nov 27, 2023
Merged

Instrument opentelemetry #4357

merged 31 commits into from
Nov 27, 2023

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Nov 3, 2023

Tracking issue

NA

Describe your changes

Instrumenting Flyte with opentelemetry to more accurately profile execution performance.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

NA

Note to reviewers

NA

Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 139 lines in your changes are missing coverage. Please review.

Comparison is base (ea72bbd) 66.81% compared to head (66606f2) 59.93%.

Files Patch % Lines
flytestdlib/otelutils/k8s.go 0.00% 50 Missing ⚠️
flytestdlib/otelutils/factory.go 50.00% 26 Missing and 6 partials ⚠️
flytestdlib/otelutils/config_flags.go 22.22% 21 Missing ⚠️
flytepropeller/pkg/controller/handler.go 88.80% 10 Missing and 5 partials ⚠️
flytepropeller/events/admin_eventsink.go 0.00% 8 Missing ⚠️
...ontroller/nodes/catalog/datacatalog/datacatalog.go 0.00% 7 Missing ⚠️
flytestdlib/otelutils/config.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4357      +/-   ##
==========================================
- Coverage   66.81%   59.93%   -6.88%     
==========================================
  Files         122      402     +280     
  Lines        7898    32828   +24930     
==========================================
+ Hits         5277    19677   +14400     
- Misses       2295    11662    +9367     
- Partials      326     1489    +1163     
Flag Coverage Δ
unittests 59.93% <55.73%> (-6.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hamersaw and others added 21 commits November 3, 2023 16:58
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Daniel Rammer <daniel@union.ai>
@hamersaw hamersaw marked this pull request as ready for review November 9, 2023 16:52
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 27, 2023
@hamersaw hamersaw merged commit 33b0c6e into master Nov 27, 2023
47 of 49 checks passed
@hamersaw hamersaw deleted the feature/open-telemetry branch November 27, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants