Update order of cluster resources config to work with both uctl and flytectl #4373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
I'm not 100% who to tag for review -- let me know if I should add / remove folks! |
samhita-alla
previously approved these changes
Nov 7, 2023
|
Hey @neverett, can you sign-off your commit so that the DCO check succeeds? You can configure automatic sign-off for all your commits. |
…lytectl Signed-off-by: nikki everett <nikki@union.ai>
neverett
force-pushed
the
nikki-update-cluster-resources-config
branch
from
44cd374
to
dc83f25
Compare
Signed-off-by: nikki everett <nikki@union.ai>
|
@samhita-alla apoogies, looks like I included an extra blank line with my first commit, which I've now removed. |
samhita-alla
approved these changes
Nov 8, 2023
|
Congrats on merging your first pull request! 🎉 |
|
@neverett, no problem! Merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4372
Describe your changes
Updates the cluster resources config to work with both
uctlandflytectl.Check all the applicable boxes
Screenshots
Not applicable
Note to reviewers
None