Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding consoleUrl parameterization based on partition #4375

Merged

Conversation

lauralindy
Copy link
Contributor

@lauralindy lauralindy commented Nov 7, 2023

Tracking issue

N/A

Describe your changes

Adds support for the Log Links for AWS gov environments instead of hard-coding to commercial

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Note to reviewers

Signed-off-by: Laura Lin <13591898+lauralindy@users.noreply.github.com>
Copy link

welcome bot commented Nov 7, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. could we add a test here?

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21b92f4) 59.59% compared to head (c91c7ba) 59.99%.

❗ Current head c91c7ba differs from pull request most recent head c2d82b8. Consider uploading reports for the commit c2d82b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
+ Coverage   59.59%   59.99%   +0.39%     
==========================================
  Files         632      562      -70     
  Lines       53621    40297   -13324     
==========================================
- Hits        31954    24175    -7779     
+ Misses      19146    13772    -5374     
+ Partials     2521     2350     -171     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...teplugins/go/tasks/plugins/webapi/athena/plugin.go 21.31% <100.00%> (+4.99%) ⬆️

... and 569 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Laura Lin <13591898+lauralindy@users.noreply.github.com>
Signed-off-by: Laura Lin <13591898+lauralindy@users.noreply.github.com>
@lauralindy
Copy link
Contributor Author

Thanks, LGTM. could we add a test here?

Added!

lauralindy and others added 2 commits November 7, 2023 10:31
Signed-off-by: Laura Lin <13591898+lauralindy@users.noreply.github.com>
@pingsutw pingsutw enabled auto-merge (squash) November 11, 2023 04:14
@pingsutw pingsutw merged commit 31748fe into flyteorg:master Nov 11, 2023
45 checks passed
Copy link

welcome bot commented Nov 11, 2023

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants