Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence NotFound when get task resource #4388

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Conversation

honnix
Copy link
Member

@honnix honnix commented Nov 8, 2023

Tracking issue

Closes #4387

Docs link

Describe your changes

Do not issue warning log when the error is NotFound because that is in most cases intended.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c4b040b) 59.59% compared to head (2617411) 59.98%.

❗ Current head 2617411 differs from pull request most recent head 412792a. Consider uploading reports for the commit 412792a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
+ Coverage   59.59%   59.98%   +0.39%     
==========================================
  Files         632      562      -70     
  Lines       53623    40291   -13332     
==========================================
- Hits        31957    24169    -7788     
+ Misses      19146    13772    -5374     
+ Partials     2520     2350     -170     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteadmin/pkg/errors/errors.go 65.82% <100.00%> (+6.99%) ⬆️
flyteadmin/pkg/manager/impl/util/shared.go 68.02% <100.00%> (+3.46%) ⬆️
.../pkg/manager/impl/executions/quality_of_service.go 64.34% <0.00%> (+2.22%) ⬆️
flyteadmin/pkg/manager/impl/executions/queues.go 84.61% <0.00%> (-7.45%) ⬇️
flyteadmin/pkg/manager/impl/util/resources.go 91.52% <0.00%> (+0.85%) ⬆️
...g/executioncluster/impl/random_cluster_selector.go 81.25% <0.00%> (+4.13%) ⬆️
flyteadmin/pkg/manager/impl/execution_manager.go 73.08% <40.00%> (+2.54%) ⬆️

... and 563 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@honnix honnix requested a review from hamersaw November 9, 2023 08:19
@honnix
Copy link
Member Author

honnix commented Nov 9, 2023

Looks like flaky tests. The CI failure is not related to this change I believe.

Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Copy link
Contributor

@hamersaw hamersaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch and thanks for the PR! A few nits, mostly my import organization OCD .. we should really automate this soon.

flyteadmin/pkg/errors/errors.go Show resolved Hide resolved
flyteadmin/pkg/manager/impl/util/resources.go Outdated Show resolved Hide resolved
honnix and others added 2 commits November 10, 2023 20:29
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
@hamersaw hamersaw merged commit 21b92f4 into flyteorg:master Nov 11, 2023
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] flyteadmin unnecessarily logs a harmless message when resource is not configured
2 participants