Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor task logs framework #4396

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Refactor task logs framework #4396

merged 3 commits into from
Nov 10, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Nov 10, 2023

Describe your changes

  • Consolidate TemplateLogPluginConfig and TemplateLogPlugin
  • Remove logPlugin struct in favor of TemplateLogPlugin
  • Add {{.generatedName}} as a template variable in the TaskExecution scheme
  • Remove deprecated GetTaskLog method, and cleanup/consolidate associated tests

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7712626) 58.14% compared to head (5f7f4a1) 57.95%.
Report is 1 commits behind head on master.

❗ Current head 5f7f4a1 differs from pull request most recent head 2194786. Consider uploading reports for the commit 2194786 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4396      +/-   ##
==========================================
- Coverage   58.14%   57.95%   -0.20%     
==========================================
  Files         466      396      -70     
  Lines       40047    29233   -10814     
==========================================
- Hits        23287    16943    -6344     
+ Misses      14875    10575    -4300     
+ Partials     1885     1715     -170     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 422 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EngHabu
EngHabu previously approved these changes Nov 10, 2023
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's clear to me the distinction between the two packages ATM?

@jeevb
Copy link
Contributor Author

jeevb commented Nov 10, 2023

I'm not sure it's clear to me the distinction between the two packages ATM?

Cleared up confusion offline. These changes do not add any extra packages. They simply cleanup existing ones. However, the lines between the logs and tasklog packages are not as clear to me now. We could consider merging them in the future.

…are specified

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb merged commit 09cb3b1 into master Nov 10, 2023
39 of 41 checks passed
@jeevb jeevb deleted the jeev/refactor-logs branch November 10, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants