Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable path filtering for monorepo components #4404

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

We want to mark certain CI checks as required, but in order to do that we cannot use path filtering (according to the docs). Once this PR is merged we'll go to the repo and mark the components checks as required.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70c23c2) 59.08% compared to head (0880000) 59.98%.

❗ Current head 0880000 differs from pull request most recent head f4803db. Consider uploading reports for the commit f4803db to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4404      +/-   ##
==========================================
+ Coverage   59.08%   59.98%   +0.90%     
==========================================
  Files         614      562      -52     
  Lines       52102    40293   -11809     
==========================================
- Hits        30782    24171    -6611     
+ Misses      18863    13773    -5090     
+ Partials     2457     2349     -108     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 570 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit c4b040b into master Nov 10, 2023
45 checks passed
@pingsutw pingsutw deleted the disable-path-filtering-for-monorepo-components branch November 10, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants