Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context for ray log template links #4416

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Nov 13, 2023

Describe your changes

Adds support for {{ .rayClusterName }} and {{ .rayJobID }} template variables in Ray plugin log template links.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Setup Process

Screenshots

Note to reviewers

Related PRs

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (033276d) 59.81% compared to head (c3207b6) 61.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4416      +/-   ##
==========================================
+ Coverage   59.81%   61.64%   +1.82%     
==========================================
  Files         632      418     -214     
  Lines       53628    35192   -18436     
==========================================
- Hits        32076    21693   -10383     
+ Misses      19027    11805    -7222     
+ Partials     2525     1694     -831     
Flag Coverage Δ
unittests 61.64% <100.00%> (+1.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
flyteplugins/go/tasks/plugins/k8s/ray/ray.go 84.94% <100.00%> (+0.53%) ⬆️

... and 214 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeevb jeevb merged commit 72e7438 into master Nov 13, 2023
45 checks passed
@jeevb jeevb deleted the jeev/ray-logs-ctx branch November 13, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants