Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Databricks Plugin Setup Doc Enhancement #4445

Merged
merged 8 commits into from
Nov 28, 2023

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Nov 17, 2023

Docs link

https://flyte--4445.org.readthedocs.build/en/4445/deployment/plugins/webapi/databricks.html#deployment-plugin-setup-webapi-databricks

Describe your changes

Add more details for data scientist to use databricks plugin more comfortable.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Related PRs

flyteorg/flytekit#1951

Future Outlier added 3 commits November 17, 2023 23:36
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Signed-off-by: Future Outlier <eric901201@gmai.com>
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98dd505) 59.73% compared to head (e7ddf54) 59.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files         636      636           
  Lines       53855    53855           
=======================================
  Hits        32169    32169           
  Misses      19154    19154           
  Partials     2532     2532           
Flag Coverage Δ
unittests 59.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pingsutw and others added 4 commits November 25, 2023 21:05
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Future Outlier <eric901201@gmai.com>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 27, 2023
@Future-Outlier Future-Outlier changed the title Databricks Plugiun Setup Doc Enhancement Databricks Plugin Setup Doc Enhancement Nov 27, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2023
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 27, 2023
@pingsutw pingsutw merged commit c300fa4 into flyteorg:master Nov 28, 2023
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants