Implemented simple echo plugin for testing #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
dosubot
bot
added
the
size:L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4489 +/- ##
==========================================
- Coverage 59.76% 59.62% -0.14%
==========================================
Files 636 638 +2
Lines 53870 53995 +125
==========================================
+ Hits 32193 32196 +3
- Misses 19146 19267 +121
- Partials 2531 2532 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
eapolinario
reviewed
Nov 28, 2023
@eapolinario so it is actually named |
eapolinario
approved these changes
Nov 29, 2023
pingsutw
approved these changes
Nov 30, 2023
Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Docs link
NA
Describe your changes
Implements a simple echo plugin which copies the task inputs to outputs. This facilitates local testing at scale without creating a large number of k8s pods. Additionally, this can support future extensions to force retries, etc.
Check all the applicable boxes
Setup Process
Enable to plugin in flyte configuration. Note that this plugin is set to be the default, so ALL tasks without a specific plugin assigned will use it. Additionally, two default plugins may not be enabled, so the PodPlugin cannot be simultaneously used.
Screenshots
NA
Note to reviewers
NA
Related PRs
NA