Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated InjectDecoder #4507

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Remove deprecated InjectDecoder #4507

merged 3 commits into from
Nov 30, 2023

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Nov 30, 2023

Tracking issue

#4508

Describe your changes

Controller Runtime deprecated (and completely removed) the dependency injection framework it used to have (review breaking changes section here: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.0). Unfortunately this breaks very silently. InjectDecoder() is the only place as far as I can tell where we rely on that functionality. When decoders are not injected, the secrets webhook fails to parse out Pods to inject secrets too.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Screenshots

Before:
image

After:
image

Note to reviewers

Related PRs

PR that upgraded Controller Runtime to the breaking version: https://github.com/flyteorg/flyte/pull/4273/files

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (7481b3d) 59.39% compared to head (50b6d4d) 59.40%.

Files Patch % Lines
flytepropeller/pkg/controller/controller.go 0.00% 6 Missing ⚠️
flytepropeller/pkg/webhook/entrypoint.go 0.00% 3 Missing ⚠️
flytepropeller/pkg/webhook/pod.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
+ Coverage   59.39%   59.40%   +0.01%     
==========================================
  Files         638      638              
  Lines       53959    53954       -5     
==========================================
+ Hits        32048    32051       +3     
+ Misses      19382    19374       -8     
  Partials     2529     2529              
Flag Coverage Δ
unittests 59.40% <28.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
@EngHabu EngHabu marked this pull request as ready for review November 30, 2023 23:04
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 30, 2023
@EngHabu EngHabu merged commit 0541851 into master Nov 30, 2023
44 of 45 checks passed
@EngHabu EngHabu deleted the webhook-deprecation branch November 30, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants